Do not strip digits, hyphens and underscores in group name ids #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://www.w3.org/TR/html4/types.html#type-id > ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by > any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), > colons (":"), and periods (".").
colszowka
added a commit
that referenced
this pull request
Oct 10, 2012
Do not strip digits, hyphens and underscores in group name ids
|
Thanks! I'll be pushing out 0.7.0 this week, which will include your updates |
|
Cool, thanks :) |
jperkin
pushed a commit
to TritonDataCenter/pkgsrc-legacy
that referenced
this pull request
Dec 9, 2013
Make this package to Ruby 1.9.3 only. v0.7.1, 2012-10-12 ([changes](simplecov-ruby/simplecov@v0.7.0...v0.7.1)) ------------------- * [BUGFIX] The gem packages of 0.7.0 (both simplecov and simplecov-html) pushed to Rubygems had some file permission issues, leading to problems when installing SimpleCov in a root/system Rubygems install and then trying to use it as a normal user (see simplecov-ruby/simplecov#171, thanks @envygeeks for bringing it up). The gem build process has been changed to always enforce proper permissions before packaging to avoid this issue in the future. v0.7.0, 2012-10-10 ([changes](simplecov-ruby/simplecov@v0.6.4...v0.7.0)) ------------------- * [FEATURE] The new `maximum_coverage_drop` and `minimum_coverage` now allow you to fail your build when the coverage dropped by more than what you allowed or is below a minimum value required. Also, `refuse_coverage_drop` disallows any coverage drops between test runs. See simplecov-ruby/simplecov#151, simplecov-ruby/simplecov#11, simplecov-ruby/simplecov#90, and simplecov-ruby/simplecov#96 (thanks to @infertux) * [FEATURE] SimpleCov now ships with a built-in MultiFormatter which allows the easy usage of multiple result formatters at the same time without the need to write custom wrapper code. See simplecov-ruby/simplecov#158 (thanks to @nikitug) * [BUGFIX] The usage of digits, hyphens and underscores in group names could lead to broken tab navigation in the default simplecov-html reports. See simplecov-ruby/simplecov-html#14 (thanks to @ebelgarts) * [REFACTORING] A few more ruby warnings removed. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#139. (thanks to @lukejahnke) * A [Pledgie button](simplecov-ruby/simplecov@63cfa99) for those that feel generous :) * The usual bunch of README fixes and documentation tweaks. Thanks to everyone who contributed those!
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 12, 2014
Make this package to Ruby 1.9.3 only. v0.7.1, 2012-10-12 ([changes](simplecov-ruby/simplecov@v0.7.0...v0.7.1)) ------------------- * [BUGFIX] The gem packages of 0.7.0 (both simplecov and simplecov-html) pushed to Rubygems had some file permission issues, leading to problems when installing SimpleCov in a root/system Rubygems install and then trying to use it as a normal user (see simplecov-ruby/simplecov#171, thanks @envygeeks for bringing it up). The gem build process has been changed to always enforce proper permissions before packaging to avoid this issue in the future. v0.7.0, 2012-10-10 ([changes](simplecov-ruby/simplecov@v0.6.4...v0.7.0)) ------------------- * [FEATURE] The new `maximum_coverage_drop` and `minimum_coverage` now allow you to fail your build when the coverage dropped by more than what you allowed or is below a minimum value required. Also, `refuse_coverage_drop` disallows any coverage drops between test runs. See simplecov-ruby/simplecov#151, simplecov-ruby/simplecov#11, simplecov-ruby/simplecov#90, and simplecov-ruby/simplecov#96 (thanks to @infertux) * [FEATURE] SimpleCov now ships with a built-in MultiFormatter which allows the easy usage of multiple result formatters at the same time without the need to write custom wrapper code. See simplecov-ruby/simplecov#158 (thanks to @nikitug) * [BUGFIX] The usage of digits, hyphens and underscores in group names could lead to broken tab navigation in the default simplecov-html reports. See simplecov-ruby/simplecov-html#14 (thanks to @ebelgarts) * [REFACTORING] A few more ruby warnings removed. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#139. (thanks to @lukejahnke) * A [Pledgie button](simplecov-ruby/simplecov@63cfa99) for those that feel generous :) * The usual bunch of README fixes and documentation tweaks. Thanks to everyone who contributed those!
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Oct 11, 2014
Make this package to Ruby 1.9.3 only. v0.7.1, 2012-10-12 ([changes](simplecov-ruby/simplecov@v0.7.0...v0.7.1)) ------------------- * [BUGFIX] The gem packages of 0.7.0 (both simplecov and simplecov-html) pushed to Rubygems had some file permission issues, leading to problems when installing SimpleCov in a root/system Rubygems install and then trying to use it as a normal user (see simplecov-ruby/simplecov#171, thanks @envygeeks for bringing it up). The gem build process has been changed to always enforce proper permissions before packaging to avoid this issue in the future. v0.7.0, 2012-10-10 ([changes](simplecov-ruby/simplecov@v0.6.4...v0.7.0)) ------------------- * [FEATURE] The new `maximum_coverage_drop` and `minimum_coverage` now allow you to fail your build when the coverage dropped by more than what you allowed or is below a minimum value required. Also, `refuse_coverage_drop` disallows any coverage drops between test runs. See simplecov-ruby/simplecov#151, simplecov-ruby/simplecov#11, simplecov-ruby/simplecov#90, and simplecov-ruby/simplecov#96 (thanks to @infertux) * [FEATURE] SimpleCov now ships with a built-in MultiFormatter which allows the easy usage of multiple result formatters at the same time without the need to write custom wrapper code. See simplecov-ruby/simplecov#158 (thanks to @nikitug) * [BUGFIX] The usage of digits, hyphens and underscores in group names could lead to broken tab navigation in the default simplecov-html reports. See simplecov-ruby/simplecov-html#14 (thanks to @ebelgarts) * [REFACTORING] A few more ruby warnings removed. See simplecov-ruby/simplecov#106 and simplecov-ruby/simplecov#139. (thanks to @lukejahnke) * A [Pledgie button](simplecov-ruby/simplecov@63cfa99) for those that feel generous :) * The usual bunch of README fixes and documentation tweaks. Thanks to everyone who contributed those!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had group names like "API V1", "API V2", but the links were stripped down the same ("APIV") and the tabs stopped working correctly.
http://www.w3.org/TR/html4/types.html#type-id