Fix for Slicer - clim/vmin/vmax - again#228
Closed
prisae wants to merge 1 commit intosimpeg:masterfrom
prisae:fix-slicer-clim
Closed
Fix for Slicer - clim/vmin/vmax - again#228prisae wants to merge 1 commit intosimpeg:masterfrom prisae:fix-slicer-clim
prisae wants to merge 1 commit intosimpeg:masterfrom
prisae:fix-slicer-clim
Conversation
Merged
Member
Author
|
This was fixed in #227 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, with #217 I re-introduced the bug reported here #189 (comment) and fixed with #189.
The confusion exists probably because there are current three ways, how to define the limits of the colourbar:
climvmin/vmaxinpcolor_optsvmin/vmaxinpcolor_opts['norm']This is not unique to the Slicer, plotSlice etc have the same.
One idea could be to deprecate the
climkeyword, in favour of the matplotlib-native way with vmin/max.