Merged
Conversation
…variable. add fixes for linux tests
Member
|
Just a note for the future. I think we should avoid such massive PRs, and try to stick to one issue per PR. Hence this one would have been better, IMHO,
Not that I would follow these guidelines thoroughly, I blame myself here too, it is more something we should probably strive for... |
This was referenced Nov 18, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of changes in here for deprecations. I will generate more details on our reasoning for this soon.
The main purpose is to move everything to a pep8 style of naming convention for modules, classes, methods, functions, and arguments.
These deprecations will likely stick around for a while (Current estimate is discretize v 1.0.0). So there should be plenty of time for users to update.
One big change is that the items such as vnC, or vnN now return tuples (immutable objects) as it is unsafe to actually change these. This was not guarded against previously. The downstream implication is that code that relied on these items being
numpy.ndarrayswill break. (i.e. things likemesh.vnC + 1will no longer work, instead something like[n+1 for n in mesh.vnC]) would likely be necessary.I have also separated out the plot commands even further into a Matplotlib mixin style class for each mesh.