Skip to content

Fix pole-zero notebook#221

Merged
kkappler merged 1 commit intomainfrom
fix_issue_220
Sep 15, 2022
Merged

Fix pole-zero notebook#221
kkappler merged 1 commit intomainfrom
fix_issue_220

Conversation

@kkappler
Copy link
Collaborator

Pole-zero ipynb no longer depends on plot_response in mt_metadata. I added an old version of plot_response into sandbox to support the notebook plotter.

[Issue(s): #220]

Pole-zero ipynb no longer depends on plot_response in mt_metadata.
I added an old version of plot_response into sandbox to support
the notebook plotter.

[Issue(s): #220]
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #221 (b43147a) into main (d666080) will decrease coverage by 0.99%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   78.96%   77.96%   -1.00%     
==========================================
  Files         101      101              
  Lines        5306     5374      +68     
==========================================
  Hits         4190     4190              
- Misses       1116     1184      +68     
Impacted Files Coverage Δ
aurora/sandbox/plot_helpers.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kkappler
Copy link
Collaborator Author

Ignoring codecov's complaint and accepting the merge because the only decrease in coverage was on a function in sandbox folder

@kkappler kkappler merged commit 6c0c63e into main Sep 15, 2022
@kkappler kkappler deleted the fix_issue_220 branch September 15, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant