?_size= argument is not persisted by hidden form fields in the table filters

[simonw]

Click "Apply" on https://covid-19.datasettes.com/covid/ny_times_us_counties?_size=1000&county__exact=San+Francisco&state__exact=California&_sort_desc=date#g.mark=line&g.x_column=date&g.x_type=temporal&g.y_column=cases&g.y_type=quantitative and the ?_size=1000 parameter from the URL will no longer apply on the reloaded page.

[simonw]

Relevant code:

datasette/datasette/views/table.py

Lines 815 to 827 in a882d67

	form_hidden_args = []
	# Add currently selected facets
	for arg in special_args:
	if arg == "_facet" or arg.startswith("_facet_"):
	form_hidden_args.extend(
	(arg, item) for item in request.args.getlist(arg)
	)
	for arg in ("_fts_table", "_fts_pk"):
	if arg in special_args:
	form_hidden_args.append((arg, special_args[arg]))
	if request.args.get("_where"):
	for where_text in request.args.getlist("_where"):
	form_hidden_args.append(("_where", where_text))

It looks like there are other arguments that may not be persisted too.

[simonw]

Should I just blanket copy over any query string argument that starts with an underscore? Any reason not to do that?

[simonw]

I'm going to copy across anything starting with an underscore.