Certain database names results in 404: "Database not found: None"

[jieter]

I have a file named test-database (1).sqlite. When requesting the home route /, I see datasette is able to read it correctly:

However, if I click any of the links, datasette replies with: Error 404 Database not found: None

It seems the hash is crucial, as renaming the file to database (1).sqlite makes the error go away.

This lines checks for a single dash:

datasette/datasette/views/base.py

Line 184 in 97fb10c

if db_name not in self.ds.databases and "-" in db_name:

$ datasette test-database\ \(1\).sqlite 
INFO:     Started server process [68314]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://127.0.0.1:8001 (Press CTRL+C to quit)
INFO:     127.0.0.1:54043 - "GET /favicon.ico HTTP/1.1" 200 OK
INFO:     127.0.0.1:54043 - "GET / HTTP/1.1" 200 OK
...
INFO:     127.0.0.1:54044 - "GET /favicon.ico HTTP/1.1" 200 OK
INFO:     127.0.0.1:54044 - "GET /test-database (1) HTTP/1.1" 404 Not Found

Version:

$ datasette --version
datasette, version 0.53

[simonw]

Yes, that logic is definitely at fault. It looks like it applies urllib.parse.unquote_plus() AFTER it's tried to do the - hash splitting thing, which is why it's failing here:

datasette/datasette/views/base.py

Lines 184 to 198 in 97fb10c

	if db_name not in self.ds.databases and "-" in db_name:
	# No matching DB found, maybe it's a name-hash?
	name_bit, hash_bit = db_name.rsplit("-", 1)
	if name_bit not in self.ds.databases:
	raise NotFound(f"Database not found: {name}")
	else:
	name = name_bit
	hash = hash_bit
	else:
	name = db_name
	name = urllib.parse.unquote_plus(name)
	try:
	db = self.ds.databases[name]
	except KeyError:
	raise NotFound(f"Database not found: {name}")

[simonw]

I'm going to add a unit test that tries a variety of weird database names.

[simonw]

Here's the incomplete sketch of a test - to go at the bottom of test_cli.py.

@pytest.mark.parametrize(
    "filename", ["test-database (1).sqlite", "database (1).sqlite"]
)
def test_weird_database_names(ensure_eventloop, tmpdir, filename):
    # https://github.com/simonw/datasette/issues/1181
    runner = CliRunner()
    db_path = str(tmpdir / filename)
    sqlite3.connect(db_path).execute("vacuum")
    result1 = runner.invoke(cli, [db_path, "--get", "/"])
    assert result1.exit_code == 0, result1.output
    homepage_html = result1.output
    assert False

[rayvoelker]

I wonder if I'm encountering the same bug (or something related). I had previously been using the .csv feature to run queries and then fetch results for the pandas read_csv() function, but it seems to have stopped working recently.

https://ilsweb.cincinnatilibrary.org/collection-analysis/collection-analysis/current_collection-3d56dbf.csv?sql=select%0D%0A++*%0D%0Afrom%0D%0A++bib%0D%0Alimit%0D%0A++100&_size=max

Datasette v0.59.4