-
Notifications
You must be signed in to change notification settings - Fork 15
fts: Update hard coded limits #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BrianJKoopman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds fine to me, but I have a few questions:
- Will this agent be used with the ACT FTS again ever?
- Does the ACT FTS have some protection in hardware from moving past this 74.8 limit, like a limit switch?
Also, please update the docstring a couple lines below this change to state the new limits.
No, I don't expect it to be used with the ACT FTS again unless something were to happen to the SO FTS and we needed to use a backup. The ACT FTS does not have limit switches but the travel is generally bounded by a metal cutout on the base of the FTS from which the mirror on the stage sticks out, so I expect that would set a hard limit. Docstring updated with the new limits. |
|
Hey Brain, Sorry about the late response — I missed this last week, but responded to it this morning on GitHub, let me know if you don't see the response.
Thanks,
Shreya
…________________________________
From: Brian Koopman ***@***.***>
Sent: Wednesday, November 26, 2025 9:58 AM
To: simonsobs/socs ***@***.***>
Cc: Shreya Sutariya ***@***.***>; Assign ***@***.***>
Subject: Re: [simonsobs/socs] FTS: updated hard coded limits (PR #954)
@BrianJKoopman commented on this pull request.
This sounds fine to me, but I have a few questions:
* Will this agent be used with the ACT FTS again ever?
* Does the ACT FTS have some protection in hardware from moving past this 74.8 limit, like a limit switch?
Also, please update the docstring a couple lines below this change to state the new limits.
—
Reply to this email directly, view it on GitHub<#954 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATUUVXMKUJKACIKQDFGGMTD36XE2ZAVCNFSM6AAAAACNCN2M5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMJRGY2TIOBVHE>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
BrianJKoopman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering those questions, and for the docstring change!
|
Thank you, Brian! And apologies for the autocorrect misspelling in the last email..
…________________________________
From: Brian Koopman ***@***.***>
Sent: Monday, December 1, 2025 6:55 PM
To: simonsobs/socs ***@***.***>
Cc: Shreya Sutariya ***@***.***>; Assign ***@***.***>
Subject: Re: [simonsobs/socs] FTS: updated hard coded limits (PR #954)
Merged #954<#954> into main.
—
Reply to this email directly, view it on GitHub<#954 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATUUVXOZX7X55PEMUBACSI337TPOZAVCNFSM6AAAAACNCN2M5KVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRGI4TCNZWGA4DSMA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
Description
Needed to expand the hard limits for the FTS agent because the agent was previously for the ACT FTS. The current FTS is the SO FTS, which has a larger stage allowing for a wider range of motion. It uses an Aerotech controller still, allowing us to use the previous agent modified with the expanded limits. This SO FTS will stay at the site and will be used for SAT and LAT bandpass measurements.
Motivation and Context
The previous hard limits were preventing us from testing the SO FTS mirror stage at its limits of travel. Changing the limits from +/- 74.8 mm to +/-80 mm allowed us to command and test the FTS mirror stage at its limits of travel.
How Has This Been Tested?
Tested on the hardware at site.
Types of changes
Checklist: