Skip to content

Conversation

@ShreyaSut
Copy link
Contributor

Description

Needed to expand the hard limits for the FTS agent because the agent was previously for the ACT FTS. The current FTS is the SO FTS, which has a larger stage allowing for a wider range of motion. It uses an Aerotech controller still, allowing us to use the previous agent modified with the expanded limits. This SO FTS will stay at the site and will be used for SAT and LAT bandpass measurements.

Motivation and Context

The previous hard limits were preventing us from testing the SO FTS mirror stage at its limits of travel. Changing the limits from +/- 74.8 mm to +/-80 mm allowed us to command and test the FTS mirror stage at its limits of travel.

How Has This Been Tested?

Tested on the hardware at site.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@ShreyaSut ShreyaSut requested a review from davidvng November 24, 2025 22:21
@ShreyaSut ShreyaSut self-assigned this Nov 24, 2025
@BrianJKoopman BrianJKoopman self-requested a review November 26, 2025 15:56
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds fine to me, but I have a few questions:

  • Will this agent be used with the ACT FTS again ever?
  • Does the ACT FTS have some protection in hardware from moving past this 74.8 limit, like a limit switch?

Also, please update the docstring a couple lines below this change to state the new limits.

@ShreyaSut
Copy link
Contributor Author

This sounds fine to me, but I have a few questions:

  • Will this agent be used with the ACT FTS again ever?
  • Does the ACT FTS have some protection in hardware from moving past this 74.8 limit, like a limit switch?

Also, please update the docstring a couple lines below this change to state the new limits.

No, I don't expect it to be used with the ACT FTS again unless something were to happen to the SO FTS and we needed to use a backup. The ACT FTS does not have limit switches but the travel is generally bounded by a metal cutout on the base of the FTS from which the mirror on the stage sticks out, so I expect that would set a hard limit.

Docstring updated with the new limits.

@ShreyaSut
Copy link
Contributor Author

ShreyaSut commented Dec 1, 2025 via email

@BrianJKoopman BrianJKoopman self-requested a review December 2, 2025 00:53
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering those questions, and for the docstring change!

@BrianJKoopman BrianJKoopman merged commit b0b2250 into main Dec 2, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the fts-update branch December 2, 2025 00:54
@BrianJKoopman BrianJKoopman changed the title FTS: updated hard coded limits fts: Update hard coded limits Dec 2, 2025
@ShreyaSut
Copy link
Contributor Author

ShreyaSut commented Dec 3, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants