Skip to content

tc400: Fix expected turbo response to 'unready_turbo' #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianJKoopman merged 2 commits into from
Sep 22, 2025
Merged

tc400: Fix expected turbo response to 'unready_turbo' #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b5257
Fixed expected turbo response to 'unready_turbo'
mjrand Sep 20, 2025
5a6a452
Fixed integration
mjrand Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion socs/agents/pfeiffer_tc400/drivers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def unready_turbo(self):
if turbo_response not in PFEIFFER_BOOL:
raise ValueError(f"Unrecognized response from turbo: {turbo_response}")
else:
return turbo_response == "111111"
return turbo_response == "000000"

def ready_turbo(self):
"""Readies the turbo for spinning. Does not cause the turbo to spin up.
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/test_pfeiffer_tc400_agent_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def test_pfeiffer_tc400_turn_turbo_off(wait_for_crossbar, emulator, run_agent,
client.init()

responses = {'0011002306000000013': format_reply('000000'), # turn_turbo_motor_off()
'0011001006000000009': format_reply('111111'), # unready_turbo()
'0011001006000000009': format_reply('000000'), # unready_turbo()
}
emulator.define_responses(responses)

Expand Down Expand Up @@ -140,7 +140,7 @@ def test_pfeiffer_tc400_turn_turbo_off_failed_unready(wait_for_crossbar,
client.init()

responses = {'0011002306000000013': format_reply('000000'), # turn_turbo_motor_off()
'0011001006000000009': format_reply('000000'), # unready_turbo()
'0011001006000000009': format_reply('111111'), # unready_turbo()
}
emulator.define_responses(responses)

Expand Down