Skip to content

Conversation

@mjrand
Copy link
Contributor

@mjrand mjrand commented Sep 20, 2025

Description

Changed the expected response of the turbo in the unready_turbo driver call.

Motivation and Context

When the turbo receives the unready_turbo command it response with a PFEIFFER_FALSE (000000) and not a PFEIFFER_TRUE (111111). We assumed it would respond the opposite, so our check of if the function succeeded always incorrectly returned a failed state. We fixed this for the turn_turbo_off command but forgot this call.

How Has This Been Tested?

This specifically was not tested but the turn_turbo_off fix was tested. Indeed when I looked at the agent logs I see that the "setting ready state failed` now instead of the turn off failure.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman self-requested a review September 22, 2025 14:13
@BrianJKoopman BrianJKoopman removed their assignment Sep 22, 2025
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@BrianJKoopman BrianJKoopman merged commit 264f206 into main Sep 22, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the fix_pfeiffer_tc400_turn_off_bug branch September 22, 2025 14:16
@BrianJKoopman BrianJKoopman changed the title Fixed expected turbo response to 'unready_turbo' tc400: Fix expected turbo response to 'unready_turbo' Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants