Skip to content

ls425: Make acq process robust to serial read errors #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianJKoopman merged 3 commits into from
Sep 16, 2025
Merged

ls425: Make acq process robust to serial read errors #926

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f231ce
auto reconnection of ls425
ykyohei Sep 10, 2025
f42b8bb
fix typo
ykyohei Sep 11, 2025
bf2859a
make exception handing more specific
ykyohei Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion socs/agents/lakeshore425/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import os
import time

import serial
import txaio
from ocs import ocs_agent, site_config
from ocs.ocs_twisted import TimeoutLock
Expand Down Expand Up @@ -123,13 +124,42 @@ def acq(self, session, params):

last_release = time.time()
while self.take_data:
if self.dev is None:
try:
self.dev = ls.LakeShore425(self.port)
self.log.info('Connected to LS425')
except (ConnectionRefusedError, serial.serialutil.SerialException):
self.log.error(
"Could not connect to LS425. "
"Retrying after 30 sec..."
)
time.sleep(30)
continue
if time.time() - last_release > 1.:
last_release = time.time()
if not self.lock.release_and_acquire(timeout=10):
self.log.warn(f"Failed to re-acquire lock, currently held by {self.lock.job}.")
continue

Bfield = self.dev.get_field()
try:
Bfield = self.dev.get_field()
except serial.serialutil.SerialException:
self.log.error(
"Decive reports readiness to read but returned no data. "
"Reconnect to LS425."
)
self.dev.close()
self.dev = None
session.degraded = True
continue
except Exception as e:
self.log.error(f"Caught unexpected {type(e).__name__} during get_field:")
self.log.error(f" {e}")
self.dev.close()
self.dev = None
session.degraded = True
continue

current_time = time.time()
data = {
'timestamp': current_time,
Expand All @@ -141,6 +171,7 @@ def acq(self, session, params):
session.data.update({'timestamp': current_time})
self.agent.feeds['mag_field'].flush_buffer()

session.degraded = False
time.sleep(sleep_time)

return True, 'Acquisition exited cleanly.'
Expand Down