Skip to content

Conversation

@ykyohei
Copy link
Contributor

@ykyohei ykyohei commented Sep 11, 2025

Description

Implement auto reconnection to ls425 agent,

Motivation and Context

satp3 ls425 had intermittent usb connection issue.

2025-09-10T15:58:15+0000 acq:1 CRASH: [Failure instance: Traceback: <class 'serial.serialutil.SerialException'>: device reports readiness to read but returned no data (device disconnected or multiple access on port?)
2025-09-10T16:04:49+0000 acq:4 CRASH: [Failure instance: Traceback: <class 'serial.serialutil.SerialException'>: write failed: [Errno 5] Input/output error

How Has This Been Tested?

tested at satp3 and confirmed that it successfully reconnect.

2025-09-10T22:03:21+0000 acq:1 Status is now "running".
2025-09-11T15:17:53+0000 Decive reports readiness to read but returned no data. Reconnect to LS425.
2025-09-11T15:17:53+0000 Could not connect to LS425. Retrying after 30 sec...
2025-09-11T15:18:23+0000 Connected to LS425
2025-09-11T15:19:53+0000 Decive reports readiness to read but returned no data. Reconnect to LS425.
2025-09-11T15:19:53+0000 Connected to LS425
2025-09-11T15:20:26+0000 Decive reports readiness to read but returned no data. Reconnect to LS425.
2025-09-11T15:20:26+0000 Could not connect to LS425. Retrying after 30 sec...
2025-09-11T15:20:56+0000 Connected to LS425

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Great to see additional connection robustness upgrades. I'd just like to see more specific error handling for the connection dropout, otherwise looks good.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the updates!

@BrianJKoopman BrianJKoopman merged commit 66dc3b8 into main Sep 16, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the ls425_reconnect branch September 16, 2025 14:35
@BrianJKoopman BrianJKoopman changed the title Auto reconnection of Lakeshore 425 agent ls425: Make acq process robust to serial read errors Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants