Skip to content

SRS CG635: Add ValueError handling #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianJKoopman merged 3 commits into from
Aug 14, 2025
Merged

SRS CG635: Add ValueError handling #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d2b97d
add ValueError handling
davidvng Aug 5, 2025
70aa6a6
Merge branch 'main' into srs-agent-fix
davidvng Aug 8, 2025
66ce608
handle error in drivers
davidvng Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion socs/agents/srs_cg635/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ def acq(self, session, params):
data['data']['Standard_CMOS_Output'] = stdc
data['data']['Running_State'] = runs
data['data']['Timebase'] = timb

except socket.timeout as e:
self.log.error(f"Timeout in retrieving clock data: {e}")
self.clock = None
Expand Down
11 changes: 8 additions & 3 deletions socs/agents/srs_cg635/drivers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,14 @@ def get_timebase(self):

def get_all_status(self):
self.write("FREQ?;STDC?;RUNS?;TIMB?")
freq, stdc, runs, timb = self.read().split(';')

return float(freq), int(stdc), int(runs), int(timb)
output = self.read()

try:
freq, stdc, runs, timb = output.split(';')
return float(freq), int(stdc), int(runs), int(timb)
except ValueError:
self.clear()
return self.get_freq(), self.get_stdc(), self.get_runs(), self.get_timebase()

def clear(self):
"""Clear all the event registers and error queue."""
Expand Down