SRS CG635: Add ValueError handling #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Member
|
Now that #913 is merged, please either rebase or merge in |
Member
|
While you're rebasing/merging, can you also provide some context and post the traceback for the error this is fixing? |
Contributor
Author
|
@BrianJKoopman Merged in main and added traceback to original post. Looks like tests passed so should be good to go. |
BrianJKoopman
requested changes
Aug 11, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Thanks, I just have one comment about the implementation here.
socs/agents/srs_cg635/agent.py
Outdated
Comment on lines
151
to
162
| try: | ||
| freq, stdc, runs, timb = self.clock.get_all_status().split(';') | ||
| data['data']['Frequency'] = float(freq) | ||
| data['data']['Standard_CMOS_Output'] = int(stdc) | ||
| data['data']['Running_State'] = int(runs) | ||
| data['data']['Timebase'] = int(timb) | ||
| except ValueError: | ||
| self.clock.clear() | ||
| data['data']['Frequency'] = self.clock.get_freq() | ||
| data['data']['Standard_CMOS_Output'] = self.clock.get_stdc() | ||
| data['data']['Running_State'] = self.clock.get_runs() | ||
| data['data']['Timebase'] = self.clock.get_timebase() |
Member
There was a problem hiding this comment.
This works, but I think would be better suited to go down a level, into the SRSCG635Interface.get_all_status() method. That way the driver is robust to this error, rather than just the agent.
BrianJKoopman
approved these changes
Aug 14, 2025
Member
BrianJKoopman
left a comment
BrianJKoopman
left a comment
There was a problem hiding this comment.
Looks great, thanks for the changes!
BrianJKoopman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ValueError handling to agent process. Attempts calling the individual driver functions individually if the combined function fails.
Motivation and Context
Error found when agent deployed to site.
Traceback from Loki logs:
The process had ran fine for about an hour, then this error occurred seemingly randomly. I assume something finicky happened when trying to read 4 registers at the same time, so this fix adds the fallback of reading the 4 registers separately.
How Has This Been Tested?
Types of changes
Checklist: