Skip to content

Conversation

@BrianJKoopman
Copy link
Member

Description

This re-enables comments, patch statuses, the verbose flag in uploads, and does an ls in the pytest workflow to verify coveage reports are generated properly.

I'll plan to leave this as is for a while until I'm convinced I understand how codecov works. I think the main problem is the stale PRs don't have base reports, and rebasing sometimes doesn't actually work to update the reporting.

Motivation and Context

PRs aren't showing their coverage status when reports are uploaded. This seems to mostly relate to the fact that the head commits don't have reports, so codecov can't report a difference in coverage. But I tried rebasing #778 to a commit that has a report and it still didn't work.

I'd like to not have codecov create comments, but having that on for now will be helpful, as those seem to report before the status checks.

How Has This Been Tested?

I've been testing a bunch of configuration changes and scenarios in a test repo. It's sort of convinced me that the configuration we have should be fine, but I still think these changes will be helpful until things are working smoothly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This re-enables comments, patch statuses, the verbose flag in uploads, and does
an ls in the pytest workflow to verify coveage reports are generated properly.

I'll plan to leave this as is for a while until I'm convinced I understand how
codecov works. I think the main problem is the stale PRs don't have base
reports, and rebasing sometimes doesn't actually work to update the reporting.
@BrianJKoopman
Copy link
Member Author

I'm going to admit defeat here, I'm not sure why coverage reports aren't working on PRs, but I'm done trying to get this to work. Closing and will revert back to using coveralls.

@BrianJKoopman BrianJKoopman deleted the koopman/codecov-debug branch November 4, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant