Skip to content

Conversation

@mhasself
Copy link
Member

@mhasself mhasself commented Oct 21, 2024

Description

This supports platforms where one generally doesn't want to move az and el axes simultaneously. When setting "axes_sequential" is enabled in acu-configs.yaml, it will perform all moves as multi-legged, separating az and el. This applies whether Sun Avoidance is on, or not. But special handling is applied, for case of Sun Avoidance.

Motivation and Context

Relates to simonsobs/scheduler#122, simonsobs/scheduler#100.

How Has This Been Tested?

Test case; tested on SATP1 today in sequential and simultaneous modes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mhasself mhasself force-pushed the mhasself/acu-seq-moves branch from ce7fe2c to 410a5bf Compare October 30, 2024 16:11
@mhasself mhasself marked this pull request as ready for review October 30, 2024 16:11
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

I'm going to rebase this before merging as a test of the recent code coverage reporting changes (the fact that you have a test addition here makes this a good test case.) I'll merge once that's done.

If enabled, this applies whether Sun Avoidance is on, or not.  But
special handling is applied, for case of Sun Avoidance.
@BrianJKoopman BrianJKoopman force-pushed the mhasself/acu-seq-moves branch from 410a5bf to 078c1b4 Compare October 31, 2024 15:49
@BrianJKoopman BrianJKoopman merged commit a38c3c6 into main Oct 31, 2024
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-seq-moves branch October 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants