Skip to content

Conversation

@ykyohei
Copy link
Contributor

@ykyohei ykyohei commented Jun 11, 2024

Make IBootState compatible with synaccess agent originally it was only compatible with ibootbar agent.

Description

Make IBootState compatible with synaccess agent and add encoder timestamp
This PR addresses #691 and #681

Motivation and Context

#691 and #681

How Has This Been Tested?

Tested in daq-dev for satp3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kyohei, this seems good to me! I have a few requests inline. Do we know why this is suddenly not working for SATp3? As far as I know, nothing in the configuration has changed recently.

@ykyohei
Copy link
Contributor Author

ykyohei commented Jun 12, 2024

Right, the configuration is not changed, and I'm confused why it was working before. supervisor agent skips IBootState monitoring if synaccess agent is down when supervisor agent is brought up, so we might have been in such an edge case. But I couldn't completely reproduce the previous state.

And I do not understand why the docker build test is failed..

@ykyohei ykyohei requested a review from jlashner June 12, 2024 14:42
Copy link
Contributor

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@jlashner jlashner merged commit 7e31eea into main Jun 19, 2024
@jlashner jlashner deleted the hwp-supervisor-outletstate branch June 19, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants