Skip to content

Remove all instances of session.set_status('running') #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrianJKoopman merged 1 commit into from
May 7, 2024
Merged

Remove all instances of session.set_status('running') #671

BrianJKoopman merged 1 commit into from
May 7, 2024

Conversation

@BrianJKoopman
Copy link
Member

@BrianJKoopman BrianJKoopman commented May 7, 2024

Description

See title.

Motivation and Context

Resolves #670.

How Has This Been Tested?

Not yet tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BrianJKoopman BrianJKoopman requested a review from jlashner May 7, 2024 02:05
@BrianJKoopman BrianJKoopman changed the title Remove all instances of session.set_status('running') Remove all instances of session.set_status('running') May 7, 2024
@BrianJKoopman BrianJKoopman added this to the v0.5.0 milestone May 7, 2024
jlashner
jlashner approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BrianJKoopman BrianJKoopman merged commit 3175b01 into main May 7, 2024
@BrianJKoopman BrianJKoopman deleted the koopman/remove-status-running branch May 7, 2024 18:40
@BrianJKoopman BrianJKoopman mentioned this pull request May 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlashner jlashner jlashner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

Remove existing session.set_status('running') status changes in agents

2 participants

@BrianJKoopman @jlashner