Skip to content

Conversation

@d-hoshino2626
Copy link
Contributor

Description

This pull request contains agent and several driver codes to handle wiregrid tilt sensors.
There are two types of tilt sensors, so two drivers are contained.

New Agent: wiregrid_tiltsensor
This agent records the data sent by tilt sensor via a serial-to-ethernet converter.
New drivers:
dwl.py: The driver to communicate DWL5000XY tilt sensor
sherborne.py: The driver to communicate with sherborne tilt sensor

Motivation and Context

Add this agent to the main branch.

How Has This Been Tested?

This agent has been tested in a test bench of wire grid at Kyoto University only with DWL tilt sensor via USB.
The test with sherborne tilt sensor has not performed yet.
Also, the test with a serial-to-ethernet converter (the same condition as at site) has not performed yet.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Sorry again for the delay in the review. Here are some comments mostly focusing on the Agent. I might have some more to say about the driver code, but these should get you started. I likely won't have time to add any more thoughts until next week.

I'm also going to push a commit that adds an outline for the docs page so I could see the nicely formatted docstrings you included for the agent's operations. (Thanks!) Can you fill in some of the detail there?

@d-hoshino2626
Copy link
Contributor Author

Thank you for reviewing, Brian! Your review is very helpful for me. I modified some codes according to your review and I added docs about this agent. If you have any question or request, please let me know freely.

@BrianJKoopman BrianJKoopman self-requested a review July 10, 2024 17:27
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes in response to the last review! And sorry this has taken so long to get back to. I have a few quick comments on the current state, and I pushed a few small commits to address a couple of small things I noticed while re-reviewing. Let me know if you have any questions.

@d-hoshino2626
Copy link
Contributor Author

Thank you for reviewing and helpful commits @BrianJKoopman! I fixed problems according to your comment. And I also found a problem in agent.py so I modified it in commit 393ea2c.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments, this is ready to merge. I just pushed one final commit to add the agent to the plugins list, I'll merge once checks complete.

@BrianJKoopman BrianJKoopman merged commit 4902d3b into main Jul 16, 2024
@BrianJKoopman BrianJKoopman deleted the develop_wiregrid_tiltsensor2 branch July 16, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants