Add Hartlap correction to CrossCorrelation likelihoods #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added configuration for tox-conda * run tests with tox-conda * data file locations and test skips * make tests run in workflow * add pytest-cov * removed codestyle env typo * added codestyle to envlist * tox-conda version for codestyle * added python version to codestyle workflow * codestyle on 3.10 specifically * flake8 fixes * do not install everything for codestyle * added temp fix for flaky sklearn install * modified installation and testing instructions * update action versions * remove inapplicable parts of astropy cookie cutter, mention conda env in INSTALL.rst * add make to conda deps
itrharrison
added
bug
mgerbino
approved these changes
Feb 1, 2023
mgerbino
pushed a commit
that referenced
this pull request
Oct 4, 2023
* added hartlap ncovsims to crosscorrelation * Implement tests with tox-conda (#92) * added configuration for tox-conda * run tests with tox-conda * data file locations and test skips * make tests run in workflow * add pytest-cov * removed codestyle env typo * added codestyle to envlist * tox-conda version for codestyle * added python version to codestyle workflow * codestyle on 3.10 specifically * flake8 fixes * do not install everything for codestyle * added temp fix for flaky sklearn install * modified installation and testing instructions * update action versions * remove inapplicable parts of astropy cookie cutter, mention conda env in INSTALL.rst * add make to conda deps * test ncovsims * added hartlap test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick patch to update the
ncovsimparameter to the CrossCorrelation likelihoods for calculating Hartlap corrections. I missed adding this as part of #81.