Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tests with tox-conda #92
Implement tests with tox-conda #92
Changes from 15 commits
74a39cc
f90dc15
57b62c1
48f4ad1
da9d36d
1d46e7b
d1d9858
167c77b
39d5acd
ec1c4a0
d599afb
54399e9
d1b2a49
a128249
b9606d0
762dce9
61893fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section was helpful, as I'm getting really slow download speeds on my laptop for some reason (~500 kB/s or less), and running with
tox-conda
was taking forever as a result (so slow in fact that tox ends up failing saying pip failed when downloading tensorflow -- which is 600 MB. I gave up on running it locally, will just look at the GitHub actions runs...) I did install everything else locally though, following the instructions here: https://github.com/simonsobs/SOLikeT/blob/dev-tox-conda-tests/INSTALL.rstAfter following those instructions, I have the conda environment setup, and the
cobaya-env
environment active, but running the tests results in:It seems camb is missing, which looks like it might be managed by
cobaya-install
? However, that looks like it thinks camb is installed:Also, I'm able to import
camb
in a python session:I should note this was done in a clean Ubuntu 22.04 machine. Also, I have only a little experience using conda, so there's a possibility I'm doing something wrong here, but I just copied and pasted the instructions linked above, so maybe I'm a good test of the instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting. camb v0.1.8.1 dates back to 2018, and the current pip version is v1.3.6 https://pypi.org/project/camb/#history which is also the version in conda https://anaconda.org/conda-forge/camb.
Can you try
tox -re test
to force recreation of the environment?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My pip download speeds seem to have improved from the last time I tried running this, so I may try to run through it from scratch again, but before doing that
tox -re test
also resulted in an error:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting from a clean Ubuntu 22.04 VM I get to this same error after following the "your own laptop/virtual machine" installation instructions and then installing
tox-conda
and runningtox -e test
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running with some verbose flags:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last update. Tests run fine when using the py310 tox environment that is used in the action workflow:
tox -e py310-test-all-latest-cov
However, using the
py37-test-oldest
doesn't, resulting in the same error as above, when running with justtest
.