FIX: Get CMS preview working for non inline-editable elements. #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
approved these changes
Jan 18, 2022
|
Have manually tested this, along with the following PRs
I've installed dnadesign/silverstripe-elemental-userforms which is a non-inline editable content block Can confirm that split-mode updates as expected after clicking the "Save" button
@GuySartorelli you'll need to rebase this PR on top of |
Fixes silverstripe#905. Depends on silverstripe/silverstripe-admin#1250 This was a feature in an earlier version of the module and most of the code is still in place.
GuySartorelli
force-pushed
the
fix/cms-preview
branch
from
66c244d
to
fbd4eaf
Compare
|
@emteknetnz Rebased on 4. Thanks (and @michalkleiner too) for looking at this! It's great to see movement on these preview PRs. |
|
All of the upstream PRs this work depends on have been merged in. |
emteknetnz
approved these changes
Jan 30, 2022
menno-rdmkr
pushed a commit
to busting-bytes/silverstripe-elemental
that referenced
this pull request
Dec 15, 2022
…rstripe#936) Fixes silverstripe#905. Depends on silverstripe/silverstripe-admin#1250 This was a feature in an earlier version of the module and most of the code is still in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #905. Depends on silverstripe/silverstripe-admin#1250
This was a feature in an earlier version of the module and most of the code is still in place.
Edit: While this technically depends on the PR from silverstripe-admin, it won't cause any defects if it does get merged in early, and merging it in even without that PR would make it easier for project-specific code to enable previews for elementals.