-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS preview doesn't work inside ItemEditForm #1251
Comments
Fixes silverstripe/silverstripe-cms#2659
Oops, looks like this should have been raised in silverstripe/silverstripe-admin, since that's where the LeftAndMain cms preview code lives. Is there a clean way to move an issue? |
@GuySartorelli moved the issue from the CMS repo. You can relink it in your PR description if you want since it changed its URL/reference now (if it didn't auto-update, looks like it might have). |
Thanks! |
I've put a list of pull requests that relate to this work in the original message. |
@brynwhyman Let's maybe bring this in sprint. |
I've just found https://userhelp.silverstripe.org/en/4/creating_pages_and_content/creating_and_editing_content/previewing_changes/ which will also probably need to be updated - if only to mention that the draft/published toggle may not be available for some content. |
@maxime-rainville Let me know if there's anything you need from me in that regard. |
@emteknetnz It might be worth keeping this ticket open while the other PRs mentioned in the description are still pending - especially docs. |
Sorry yes intend to keep open, GitHub auto-closed it due to closing a linked PR |
All PRs have been merged. Thank you once again @GuySartorelli this was a significant contribution |
Thanks for working with me to get it in! |
I figured I'd write this while these changes are fairly fresh in my mind, and save someone else the trouble. Obviously if there's some procedure ormpolicy for writing release notes that I'm not following here feel please let me know and feel free to close this PR. Refer to silverstripe/silverstripe-admin#1251 for preview PRs, silverstripe#10204 for the `GridFieldComponent` stuff, and silverstripe/silverstripe-elemental#913 for changes to elemental search indexing. There are some extra new lines in here that I can't remove from the GitHub editor - but I expect there will be other requested changes so I'll clean that up at the same time.
silverstripe/silverstripe-framework includes a separate form in
GridFieldDetailForm_ItemRequest
'sItemEditForm
whichLeftAndMain
doesn't add the necessary components to form CMS previews (cms-previewable
ExtraClass andSilverStripeNavigator
field).I think an extension class should be included as a part of this module which takes advantage of the
updateItemEditForm
extension point ofGridFieldDetailForm_ItemRequest
to add these.Edit: The following pull requests all ultimately relate to this:
And, as an extension of all of this:
The text was updated successfully, but these errors were encountered: