DOC Add SearchableDropdownField to 5.2.0 changelog #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2023
Closed
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
2 times, most recently
from
87492c1
to
9465f3f
Compare
GuySartorelli
requested changes
Dec 11, 2023
There was a problem hiding this comment.
I think we should have an entry in https://docs.silverstripe.org/en/5/developer_guides/forms/field_types/ as well, since there are some features that might not be immediately clear or that people might not even think to look for (such as allowing it to use SearchContext)
If you disagree, I won't fight you on it - but in that case it should at least get a mention in https://docs.silverstripe.org/en/5/developer_guides/forms/field_types/common_subclasses/
|
Please either make the changes requested in #412 (review) or explain why you think those changes should not be made. |
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
2 times, most recently
from
9d2dbdd
to
a6896d1
Compare
|
Have added a couple of quick one-liners for the form field subclasses |
GuySartorelli
approved these changes
Dec 13, 2023
GuySartorelli
requested changes
Dec 14, 2023
emteknetnz
force-pushed
the
pulls/5/selectorfield
branch
from
a6896d1
to
e1cc2c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-admin#1618