Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use SearchableMultiDropdownField #149

Merged
merged 1 commit into from
Dec 18, 2023
Merged

ENH Use SearchableMultiDropdownField #149

merged 1 commit into from
Dec 18, 2023

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 29, 2023 •
edited by GuySartorelli
Loading

@emteknetnz emteknetnz mentioned this pull request Nov 29, 2023
Closed
8 tasks
GuySartorelli
GuySartorelli requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove the $membersMap variable assignment

@emteknetnz
Copy link
Member Author

Have removed $membersMap variable

@emteknetnz emteknetnz marked this pull request as ready for review December 8, 2023 03:31
GuySartorelli
GuySartorelli requested changes Dec 11, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a dependency bump for admin and framework.

@emteknetnz
Copy link
Member Author

Have updated composer.json

GuySartorelli
GuySartorelli approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when admin and framework PRs have been merged.

@GuySartorelli
Copy link
Member

This is failing CI

@emteknetnz
Copy link
Member Author

Have updated behat test, though will require this new PR to be merged first - silverstripe/silverstripe-admin#1635

@GuySartorelli GuySartorelli mentioned this pull request Dec 17, 2023
Merged
GuySartorelli
GuySartorelli requested changes Dec 17, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes locally but need to remove debug steps

tests/behat/features/manage-page-permissions.feature Outdated Show resolved Hide resolved
tests/behat/features/manage-page-permissions.feature Outdated Show resolved Hide resolved
GuySartorelli
GuySartorelli approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 4fcf50a into silverstripe:5 Dec 18, 2023
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/selectorfield branch December 18, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli