Fix typography in some components #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briskt
approved these changes
Jul 1, 2021
| </style> | ||
|
|
||
| <span class="dib text-align-center white fs-16 br-50 background {$$props.class}" style="--theme-color: {color}" ><slot /></span> | ||
| <span class="mdc-typography dib text-align-center white fs-16 br-50 background {$$props.class}" style="--theme-color: {color}" ><slot /></span> |
Contributor
There was a problem hiding this comment.
Does this make Badge dependent on MDC? If so, should it move to the mdc directory?
Contributor
Author
There was a problem hiding this comment.
mdc-typography is only applied if typography is in the project, so it depends on the consumer. Also, it is not in the mdc catalog so I am still leaning toward not moving it for now.
| </style> | ||
|
|
||
| <div class="chip black flex justify-center align-items-center mb-1 mr-2 fs-14 br-16px {$$props.class}"> | ||
| <div class="mdc-typography chip black flex justify-center align-items-center mb-1 mr-2 fs-14 br-16px {$$props.class}"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Updated
Before:
After:
