Skip to content

Commit 462a7d1

Browse files
authored
Merge pull request #39 from silinternational/feature/fix-typography
Fix typography in some components
2 parents 4b2f5dc + 39a6f5b commit 462a7d1

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## [Unreleased]
8+
9+
## [2.0.0](https://github.com/silinternational/ui-components/releases/tag/v2.0.0) - 2021-07-02
810
### Changed
911
- README - Instructions for running Storybook locally
1012
- global.css is compiled during Storybook dev and deployment build from global.scss and used only for Storybook
@@ -19,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1921

2022
### Added
2123
- $$props.class to Badge, Form, CustomCard, Tour and StaticChip so they can accept global classes
24+
- mdc-typography class to Badge, StaticChip and Card as it was not being applied
2225
- Badge, CustomCard, Drawer, Form, StaticChip and Tour stories to Storybook
2326
- global.scss to generate full range of padding and margin from 1rem to 8rem, height and width from 0 to 100% in increments of 5, z-index from 0 to 10.
2427
- align-item and align-self flex utilites to global.scss

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Reusable Svelte components for some internal applications
55
To install to your Svelte project, open your project's root directory in a terminal. Type `npm i @silintl/ui-components` and press enter.
66

77
### bundler configuration
8-
Your Svelte project will need the bundler (rollup most likely) configured to compile Sass files. If you are using rollup your plugins in your "rollup.config.js" should look something like this taking special note of postcss and svelte (it may work still without autoPreprocess):
8+
Your Svelte project will need the bundler (rollup most likely) configured to compile Sass files. If you are using rollup your plugins in your "rollup.config.js" should look something like this taking special note of postcss and svelte:
99
```
1010
import postcss from 'rollup-plugin-postcss';
1111
import autoPreprocess from 'svelte-preprocess';
@@ -179,7 +179,7 @@ An example of using Drawer:
179179
```
180180

181181
### storybook
182-
Try out our components at https://silinternational.github.io/ui-components/
182+
Try out our components and see examples at https://silinternational.github.io/ui-components/
183183
or run storybook locally. Just copy this repo to your machine and run `npm install` then `npm run dev.` Storybook should open a browser window when it finishes building.
184184

185185
### CSS utility classes

components/Badge.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
}
1515
</style>
1616

17-
<span class="dib text-align-center white fs-16 br-50 background {$$props.class}" style="--theme-color: {color}" ><slot /></span>
17+
<span class="mdc-typography dib text-align-center white fs-16 br-50 background {$$props.class}" style="--theme-color: {color}" ><slot /></span>

components/StaticChip.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
}
1111
</style>
1212

13-
<div class="chip black flex justify-center align-items-center mb-1 mr-2 fs-14 br-16px {$$props.class}">
13+
<div class="mdc-typography chip black flex justify-center align-items-center mb-1 mr-2 fs-14 br-16px {$$props.class}">
1414
<div class="chip-content flex align-items-center">
1515
<slot></slot>
1616
</div>

components/mdc/Card/Card.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export let color = 'white'
1818
}
1919
</style>
2020

21-
<div class="mdc-card {$$props.class}" style="background-color: {color}" class:mdc-card--outlined={outlined}>
21+
<div class="mdc-card mdc-typography {$$props.class}" style="background-color: {color}" class:mdc-card--outlined={outlined}>
2222
{#if secondary.length}
2323
<div class="secondary-text uppercase gray">
2424
{secondary}

0 commit comments

Comments
 (0)