Skip to content

Conversation

@hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Jan 22, 2024

hobbitronics and others added 24 commits November 1, 2023 10:47
security(dependencies): add deepfactor and move svelte and material to dependencies. Remove unused deps.

skip release
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…/semver-5.7.2

build(deps-dev): bump semver from 5.7.1 to 5.7.2
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…/browserify-sign-4.2.2

build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2
…ency-issues

Use `npm audit fix` to fix some vulnerable dependency issues
feat(StaticChip): add height prop, improve defaults styles, width exp…
@hobbitronics hobbitronics requested a review from a team January 22, 2024 06:51
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with questions

README.md Outdated
## installation

To install to your Svelte project, open your project's root directory in a terminal. Type or paste `npm i -D @silintl/ui-components` and press enter. Sass and-material-components web are required to develop additional material web components in your app, but it may depend on your version of npm if they are necessary even if you don't (I haven't figured out which versions require them). Paste in `npm i -D sass@1.55.x material-components-web@14.0.0` and hit enter (versions will vary if you use an older release of this repo). You should already have svelte@3 installed if you are using this library.
To install to your Svelte project, open your project's root directory in a terminal. Type or paste `npm i -D @silintl/ui-components` and press enter. Sass (depending on your bundler and plugins) and material-components-web are required to develop additional material web components in your app, but it may depend on your version of npm if they are necessary even if you don't (I haven't figured out which versions require them). Enter the commands `material-components-web@14` and `npm i -D sass@1` (versions will vary if you use an older release of this library). You should already have svelte@3 installed if you are using this library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is material-components-web@14 really a command?

Copy link
Contributor Author

@hobbitronics hobbitronics Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, thanks

package.json Outdated
Comment on lines 48 to 52
"@storybook/addon-postcss": "^2.0.0",
"@storybook/preset-scss": "^1.0.3",
"@storybook/svelte": "^6.5.16",
"@semantic-release/changelog": "^6.0.2",
"@semantic-release/git": "^10.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why these were un-alphabetized?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just got shuffled around during the scrutinizer work.

@hobbitronics hobbitronics merged commit b271dd4 into main Jan 23, 2024
@hobbitronics
Copy link
Contributor Author

🎉 This PR is included in version 10.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants