Skip to content

Conversation

@hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Nov 1, 2023

Added

  • deepfactor action

Changed

  • moved some devDependencies to dependencies

Removed

  • 2 unused deps

@hobbitronics hobbitronics requested a review from a team November 1, 2023 01:57
@hobbitronics
Copy link
Contributor Author

I moved storybook back out of dependencies, as it did this when installing in a consumer app, which I didn't want. `mike@Michaels-Mac-mini cover-ui % npm i -D https://github.com/silinternational/ui-components#12ab2480b951fa5e324cf5f1c84209694279b9e1
npm WARN idealTree Removing dependencies.@silintl/ui-components in favor of devDependencies.@silintl/ui-components
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN skipping integrity check for git dependency ssh://git@github.com/silinternational/ui-components.git
npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
npm WARN deprecated @babel/plugin-proposal-private-methods@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-methods instead.
npm WARN deprecated @babel/plugin-proposal-nullish-coalescing-operator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated trim@0.0.1: Use String.prototype.trim() instead
npm WARN deprecated @babel/plugin-proposal-object-rest-spread@7.12.1: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
npm WARN deprecated @babel/plugin-proposal-optional-chaining@7.21.0: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
npm WARN deprecated @babel/plugin-proposal-private-property-in-object@7.21.11: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated uuid-browser@3.1.0: Package no longer supported and required. Use the uuid package or crypto.randomUUID instead
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated @babel/plugin-proposal-object-rest-spread@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-object-rest-spread instead.
npm WARN deprecated sane@4.1.0: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated fsevents@1.2.13: The v1 package contains DANGEROUS / INSECURE binaries. Upgrade to safe fsevents v2
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

added 1287 packages, removed 1 package, changed 5 packages, and audited 1840 packages in 1m`

@briskt briskt self-requested a review November 1, 2023 14:09
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this is fine, though I don't fully know the effects of things like removing sass-loader or svelte-loader.

@hobbitronics
Copy link
Contributor Author

As far as I can tell, this is fine, though I don't fully know the effects of things like removing sass-loader or svelte-loader.

These are webpack build tools we never used (probably mistakenly brought in for storybook config). Storybook build still works so shouldn't be a problem.

@hobbitronics hobbitronics merged commit 7ad66fc into develop Nov 2, 2023
@hobbitronics hobbitronics deleted the feature/deepfactor branch November 2, 2023 01:41
@hobbitronics hobbitronics mentioned this pull request Jan 22, 2024
@hobbitronics
Copy link
Contributor Author

🎉 This PR is included in version 10.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants