Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic bundle tests #69

Merged
merged 21 commits into from
May 3, 2023
Merged

Basic bundle tests #69

merged 21 commits into from
May 3, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented Apr 19, 2023

Adapts existing tests to cover the bundle flow (empty materials, mismatched materials, ...) To this effect, extends SigstoreClient to support the *-bundle subcommands.

Depends on #51.
Resolves #65.

Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown marked this pull request as ready for review May 3, 2023 17:10
@tnytown tnytown changed the title WIP: Basic bundle tests Basic bundle tests May 3, 2023
@tnytown
Copy link
Collaborator Author

tnytown commented May 3, 2023

This changeset is still a bit messy, but I'd like to get some eyes on it!

test/client.py Outdated Show resolved Hide resolved
test/conftest.py Outdated Show resolved Hide resolved
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, a couple of notes about naming and documentation.

Signed-off-by: Andrew Pan <a@tny.town>
test/client.py Outdated Show resolved Hide resolved
test/conftest.py Outdated Show resolved Hide resolved
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown requested a review from woodruffw May 3, 2023 18:30
Signed-off-by: Andrew Pan <a@tny.town>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; great work @tnytown!

@woodruffw woodruffw merged commit 5766a8a into sigstore:main May 3, 2023
@woodruffw woodruffw deleted the ap/issue/65 branch May 3, 2023 18:40
tnytown added a commit to trail-of-forks/sigstore-conformance that referenced this pull request May 8, 2023
Fixes bad merge in sigstore#69.

Signed-off-by: Andrew Pan <a@tny.town>
woodruffw added a commit that referenced this pull request May 27, 2023
* test, tools: init bundle cert chain tests

Signed-off-by: Andrew Pan <a@tny.town>

* Makefile: adjust `lint` to cover `tools/`

Signed-off-by: Andrew Pan <a@tny.town>

* mypy.ini: checkin

Signed-off-by: Andrew Pan <a@tny.town>

* treewide: remove ski/aki test

Signed-off-by: Andrew Pan <a@tny.town>

* conftest: re-add `--identity-token`

Fixes bad merge in #69.

Signed-off-by: Andrew Pan <a@tny.town>

* test_bundle: guard `BasicConstraints` query w/ try

Signed-off-by: Andrew Pan <a@tny.town>

* workflows/conformance.yml: test the PR branch

Signed-off-by: Andrew Pan <a@tny.town>

---------

Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: Andrew Pan <3821575+tnytown@users.noreply.github.com>
Co-authored-by: William Woodruff <william@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for bundle support
2 participants