-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic bundle tests #69
Conversation
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
This changeset is still a bit messy, but I'd like to get some eyes on it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, a couple of notes about naming and documentation.
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; great work @tnytown!
Fixes bad merge in sigstore#69. Signed-off-by: Andrew Pan <a@tny.town>
* test, tools: init bundle cert chain tests Signed-off-by: Andrew Pan <a@tny.town> * Makefile: adjust `lint` to cover `tools/` Signed-off-by: Andrew Pan <a@tny.town> * mypy.ini: checkin Signed-off-by: Andrew Pan <a@tny.town> * treewide: remove ski/aki test Signed-off-by: Andrew Pan <a@tny.town> * conftest: re-add `--identity-token` Fixes bad merge in #69. Signed-off-by: Andrew Pan <a@tny.town> * test_bundle: guard `BasicConstraints` query w/ try Signed-off-by: Andrew Pan <a@tny.town> * workflows/conformance.yml: test the PR branch Signed-off-by: Andrew Pan <a@tny.town> --------- Signed-off-by: Andrew Pan <a@tny.town> Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: Andrew Pan <3821575+tnytown@users.noreply.github.com> Co-authored-by: William Woodruff <william@trailofbits.com>
Adapts existing tests to cover the bundle flow (empty materials, mismatched materials, ...) To this effect, extends
SigstoreClient
to support the*-bundle
subcommands.Depends on #51.
Resolves #65.