-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for bundle support #65
Comments
How are we specifying bundles? Currently the cli interface (interface interface?) in sigstore-java allows specifying either sig/cert output files or a bundle output file. But I think from our last slack discussion, it wasn't clear if the python cli could enforce those constraints? |
@tnytown will figure that out as part of #51 first. But I think we can/should make the spec match In the current spec, there's an emphasis on guaranteeing that flags are in order and are non-optional, etc for ease of argument parsing. I think we should mostly get rid of that emphasis and allow:
or
That way, the CLI isn't only useful for conformance testing but is more ergonomic for general use like what you're using it for with |
Just got to this. I slightly prefer separating the two different flows (sig+crt vs. bundle) into different subcommands, as this makes it clear to confused users which flags are valid together. In this scenario, |
#66 contains some concrete examples of test cases we'll want to exercise with this functionality. |
Once #51 is done, we should look at exercising bundle support. We should write some basic unit tests exercising that bundles are created correctly and can be verified with the same client.
The text was updated successfully, but these errors were encountered: