Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation of LCLI #6243

Closed
wants to merge 1 commit into from
Closed

Fix compilation of LCLI #6243

wants to merge 1 commit into from

Conversation

AgeManning
Copy link
Member

I think #5922 broke the compilation of LCLI.

Seems like no one has compiled it in a few months.

I think this PR fixes it.

@AgeManning AgeManning added the ready-for-review The code is ready for review label Aug 8, 2024
@jimmygchen
Copy link
Member

Oh I actually broke this recently in #6189, @jxs made the same fix in #6234. Going to merge it now.

@jimmygchen
Copy link
Member

Thanks for the fix! I'm closing this one as a duplicate

@jimmygchen jimmygchen closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul Awaiting requested review from michaelsproul

Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgeManning @jimmygchen