Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extern crate #5922

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Remove extern crate #5922

merged 1 commit into from
Jun 17, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

As of Rust 2018 (which we use), extern crate is unnecessary, and kinda janky.

This PR removes all uses of extern crate in favour of regular uses.

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Jun 13, 2024
realbigsean
realbigsean approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realbigsean
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jun 13, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jun 13, 2024
@mergify
Merge of #5922
fd6dd0b
@mergify mergify bot mentioned this pull request Jun 13, 2024
Closed
5 tasks
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 17, 2024
@realbigsean
Copy link
Member

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Jun 17, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Jun 17, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 21f3a19

mergify bot added a commit that referenced this pull request Jun 17, 2024
@mergify
Merge of #5922
e5b5fcd
This was referenced Jun 17, 2024
Closed
Merged
Merged
Merged
@mergify mergify bot merged commit 21f3a19 into sigp:unstable Jun 17, 2024
28 checks passed
@AgeManning AgeManning mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees
No one assigned
Labels
code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelsproul @realbigsean @jimmygchen