Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency whoami #5351

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update dependency whoami #5351

merged 1 commit into from
Mar 6, 2024

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Mar 5, 2024 •
edited
Loading

Issue Addressed

cargo audit caught a dependency that needs to be udpated:
https://github.com/sigp/lighthouse/actions/runs/8150980686/job/22278141087?pr=5350

Bump whoami version due to this audit report:
https://rustsec.org/advisories/RUSTSEC-2024-0020

@jimmygchen jimmygchen added ready-for-review The code is ready for review dependencies Pull requests that update a dependency file labels Mar 5, 2024
@jimmygchen jimmygchen changed the title Update dependency Update dependency whoami Mar 5, 2024
pawanjay176
pawanjay176 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 6, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

queue

🟠 The pull request is the 1st in the queue to be merged

#5351 is queued for merge.

Required conditions of queue default for merge:

  • check-success=local-testnet-success
  • check-success=test-suite-success

Required conditions to stay in the queue:

  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success=Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 1
      • check-success=license/cla
      • check-success=target-branch-check

Visit the Mergify Dashboard to check the state of the queue default.

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 6, 2024
@mergify
Merge of #5351
337d1a8
This was referenced Mar 6, 2024
Closed
Merged
@michaelsproul
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6aebb49

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

requeue

☑️ This pull request is already queued

1 similar comment
@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

requeue

☑️ This pull request is already queued

mergify bot added a commit that referenced this pull request Mar 6, 2024
@mergify
Merge of #5351
9a2810f
This was referenced Mar 6, 2024
Closed
Merged
@jimmygchen
Copy link
Member Author

@mergify dequeue

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member Author

@mergify requeue

@jimmygchen
Copy link
Member Author

@Mergifyio requeue

@jimmygchen
Copy link
Member Author

@mergify requeue

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

requeue

☑️ This pull request is already queued

@mergify mergify bot merged commit 6aebb49 into sigp:unstable Mar 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmygchen @michaelsproul @pawanjay176