Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 5288: Doesn't POST if attestations is empty. #5318

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fix 5288: Doesn't POST if attestations is empty. #5318

merged 3 commits into from
Mar 7, 2024

Conversation

kamuik16
Copy link
Contributor

Issue Addressed

#5288

Proposed Changes

Checks if the attestations vec is empty then logs a message WARN No attestations were published and returns.

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kamuik16 kamuik16 mentioned this pull request Feb 27, 2024
Closed
@michaelsproul michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label Feb 27, 2024
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 28, 2024
michaelsproul
michaelsproul approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v5.1.0 Q2 2024 and removed ready-for-review The code is ready for review labels Mar 5, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Mar 5, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 5, 2024
@mergify
Merge of #5318
b880179
@mergify mergify bot mentioned this pull request Mar 5, 2024
Closed
5 tasks
@michaelsproul
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 6, 2024
@mergify
Merge of #5318
ef465d6
This was referenced Mar 6, 2024
Closed
Merged
mergify bot added a commit that referenced this pull request Mar 6, 2024
@mergify
Merge of #5318
4542c13
@mergify mergify bot mentioned this pull request Mar 6, 2024
Closed
5 tasks
@michaelsproul
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #5318 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 6, 2024
@mergify
Merge of #5318
733a8b7
This was referenced Mar 6, 2024
Closed
Merged
@jimmygchen
Copy link
Member

@mergify dequeue

@mergify Mergify
Copy link

mergify bot commented Mar 6, 2024

dequeue

✅ The pull request has been removed from the queue default

@jimmygchen
Copy link
Member

@mergify requeue

@michaelsproul
Copy link
Member

@Mergifyio queue

@michaelsproul Mergify
Copy link
Member

@Mergifyio dequeue

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

dequeue

☑️ The pull request is not queued

@michaelsproul Mergify
Copy link
Member

@Mergifyio requeue default

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

requeue default

✅ This pull request will be re-embarked automatically

The followup queue default command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024 •
edited
Loading

queue default

✅ The pull request has been merged automatically

The pull request has been merged automatically at b961457

mergify bot added a commit that referenced this pull request Mar 7, 2024
@mergify
Merge of #5318
b91a467
@mergify mergify bot mentioned this pull request Mar 7, 2024
Closed
5 tasks
@michaelsproul
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

requeue

☑️ This pull request is already queued

@mergify mergify bot merged commit b961457 into sigp:unstable Mar 7, 2024
29 checks passed
@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b961457

@mergify Mergify
Copy link

mergify bot commented Mar 7, 2024

refresh

✅ Pull request refreshed

@kamuik16 kamuik16 deleted the issue5288 branch March 7, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. v5.1.0 Q2 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kamuik16 @CLAassistant @michaelsproul @jimmygchen @kamuikatsurgi