[Merged by Bors] - Optimistic sync spec tests (v1.2.0) #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
test improvement
michaelsproul
changed the title
michaelsproul
added
ready-for-review
|
Ready for review assuming this passes CI. This will conflict slightly with #3235, so I'm happy if we merge that first. |
paulhauner
approved these changes
Oct 15, 2022
There was a problem hiding this comment.
What a clean and easy impl, well done to @hwwhww for the design ❤️
I like the canned responses keyed by block hash, nice addition.
Looks good, happy to merge once our lord and savoir clippy has been appeased.
paulhauner
added
waiting-on-author
michaelsproul
added
ready-for-merge
|
Thanks! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2022
## Issue Addressed Implements new optimistic sync test format from ethereum/consensus-specs#2982. ## Proposed Changes - Add parsing and runner support for the new test format. - Extend the mock EL with a set of canned responses keyed by block hash. Although this doubles up on some of the existing functionality I think it's really nice to use compared to the `preloaded_responses` or static responses. I think we could write novel new opt sync tests using these primtives much more easily than the previous ones. Forks are natively supported, and different responses to `forkchoiceUpdated` and `newPayload` are also straight-forward. ## Additional Info Blocked on merge of the spec PR and release of new test vectors.
|
Pull request successfully merged into unstable. Build succeeded:
|
bors
bot
changed the title
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed Implements new optimistic sync test format from ethereum/consensus-specs#2982. ## Proposed Changes - Add parsing and runner support for the new test format. - Extend the mock EL with a set of canned responses keyed by block hash. Although this doubles up on some of the existing functionality I think it's really nice to use compared to the `preloaded_responses` or static responses. I think we could write novel new opt sync tests using these primtives much more easily than the previous ones. Forks are natively supported, and different responses to `forkchoiceUpdated` and `newPayload` are also straight-forward. ## Additional Info Blocked on merge of the spec PR and release of new test vectors.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Implements new optimistic sync test format from ethereum/consensus-specs#2982. - Add parsing and runner support for the new test format. - Extend the mock EL with a set of canned responses keyed by block hash. Although this doubles up on some of the existing functionality I think it's really nice to use compared to the `preloaded_responses` or static responses. I think we could write novel new opt sync tests using these primtives much more easily than the previous ones. Forks are natively supported, and different responses to `forkchoiceUpdated` and `newPayload` are also straight-forward. Blocked on merge of the spec PR and release of new test vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Implements new optimistic sync test format from ethereum/consensus-specs#2982.
Proposed Changes
preloaded_responsesor static responses. I think we could write novel new opt sync tests using these primtives much more easily than the previous ones. Forks are natively supported, and different responses toforkchoiceUpdatedandnewPayloadare also straight-forward.Additional Info
Blocked on merge of the spec PR and release of new test vectors.