[Merged by Bors] - Add a new bls test #3235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsluedem
force-pushed
the
add-bls-tests
branch
3 times, most recently
from
c8daf66 to
b5b4074
Compare
|
hi @zsluedem is this ready for review? |
@michaelsproul There is one thing which I am not sure. Do you need the tests |
paulhauner
requested changes
Oct 4, 2022
There was a problem hiding this comment.
This is super clean and tidy, I couldn't have suggested a better method of implementation 🚀
I apologise for letting this PR linger for so long, it's a great contribution and deserved to be merged sooner.
I have a few suggestions here, mostly just minor nit-picks. If I'm clever enough, you might be able to just commit the suggestions and still compile and get past the linter (spoiler, I'm probably not clever enough).
There is a merge conflict for which I couldn't resolve via a suggestion. That should be an easy fix though.
Once again, thanks for this. If you're able to address these comments I'll make sure it gets merged quickly 🙏
paulhauner
added
waiting-on-author
zsluedem
force-pushed
the
add-bls-tests
branch
3 times, most recently
from
425394e to
b952b7f
Compare
zsluedem
force-pushed
the
add-bls-tests
branch
from
b952b7f to
6ff5dbf
Compare
|
@paulhauner Conflicts resolved and comments addressed. |
michaelsproul
added
ready-for-review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
## Issue Addressed Which issue # does this PR address? #2629 ## Proposed Changes Please list or describe the changes introduced by this PR. 1. ci would dowload the bls test cases from https://github.com/ethereum/bls12-381-tests/ 2. all the bls test cases(except eth ones) would use cases in the archive from step one 3. The bls test cases from https://github.com/ethereum/consensus-spec-tests would stay there and no use . For the future , these bls test cases would be remove suggested from ethereum/consensus-spec-tests#25 . So it would do no harm and compatible for future cases. ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Question: I am not sure if I should implement tests about `deserialization_G1`, `deserialization_G2` and `hash_to_G2` for the issue.
|
Pull request successfully merged into unstable. Build succeeded:
|
macladson
pushed a commit
to macladson/lighthouse
that referenced
this pull request
Jan 5, 2023
## Issue Addressed Which issue # does this PR address? sigp#2629 ## Proposed Changes Please list or describe the changes introduced by this PR. 1. ci would dowload the bls test cases from https://github.com/ethereum/bls12-381-tests/ 2. all the bls test cases(except eth ones) would use cases in the archive from step one 3. The bls test cases from https://github.com/ethereum/consensus-spec-tests would stay there and no use . For the future , these bls test cases would be remove suggested from ethereum/consensus-spec-tests#25 . So it would do no harm and compatible for future cases. ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Question: I am not sure if I should implement tests about `deserialization_G1`, `deserialization_G2` and `hash_to_G2` for the issue.
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed Which issue # does this PR address? sigp#2629 ## Proposed Changes Please list or describe the changes introduced by this PR. 1. ci would dowload the bls test cases from https://github.com/ethereum/bls12-381-tests/ 2. all the bls test cases(except eth ones) would use cases in the archive from step one 3. The bls test cases from https://github.com/ethereum/consensus-spec-tests would stay there and no use . For the future , these bls test cases would be remove suggested from ethereum/consensus-spec-tests#25 . So it would do no harm and compatible for future cases. ## Additional Info Please provide any additional information. For example, future considerations or information useful for reviewers. Question: I am not sure if I should implement tests about `deserialization_G1`, `deserialization_G2` and `hash_to_G2` for the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Which issue # does this PR address?
#2629
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.
Question:
I am not sure if I should implement tests about
deserialization_G1,deserialization_G2andhash_to_G2for the issue.