[Merged by Bors] - Add client authentication to Web3Signer validators #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
petertdavies
force-pushed
the
client-authentication
branch
from
022ef0d to
1f8f9a1
Compare
|
I'm struggling to reproduce the |
Agree, based on this error it looks like an EE bug, which might have been fixed in the meantime (we depend on unpinned versions of Geth's master branch and Nethermind's |
paulhauner
reviewed
May 18, 2022
paulhauner
added
waiting-on-author
|
Beautiful! Thanks again. bors r+ |
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
May 18, 2022
## Issue Addressed Web3Signer validators do not support client authentication. This means the `--tls-known-clients-file` option on Web3Signer can't be used with Lighthouse. ## Proposed Changes Add two new fields to Web3Signer validators, `client_identity_path` and `client_identity_password`, which specify the path and password for a PKCS12 file containing a certificate and private key. If `client_identity_path` is present, use the certificate for SSL client authentication. ## Additional Info I am successfully validating on Prater using client authentication with Web3Signer and client authentication.
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Web3Signer validators do not support client authentication. This means the
--tls-known-clients-fileoption on Web3Signer can't be used with Lighthouse.Proposed Changes
Add two new fields to Web3Signer validators,
client_identity_pathandclient_identity_password, which specify the path and password for a PKCS12 file containing a certificate and private key. Ifclient_identity_pathis present, use the certificate for SSL client authentication.Additional Info
I am successfully validating on Prater using client authentication with Web3Signer and client authentication.