Fix tests/clippy

sigp · May 10, 2022 · 1f8f9a1 · 1f8f9a1
1 parent 1bb997b
commit 1f8f9a1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/testing/web3signer_tests/src/lib.rs b/testing/web3signer_tests/src/lib.rs
@@ -358,6 +358,8 @@ mod tests {
                         url: signer_rig.url.to_string(),
                         root_certificate_path: Some(root_certificate_path()),
                         request_timeout_ms: None,
+                        client_identity_path: None,
+                        client_identity_password: None,
                     },
                 };
                 ValidatorStoreRig::new(vec![validator_definition], spec).await

diff --git a/validator_client/src/http_api/tests.rs b/validator_client/src/http_api/tests.rs
@@ -457,6 +457,8 @@ impl ApiTester {
                     url: format!("http://signer_{}.com/", i),
                     root_certificate_path: None,
                     request_timeout_ms: None,
+                    client_identity_path: None,
+                    client_identity_password: None,
                 }
             })
             .collect();

diff --git a/validator_client/src/http_api/tests/keystores.rs b/validator_client/src/http_api/tests/keystores.rs
@@ -40,6 +40,8 @@ fn web3signer_validator_with_pubkey(pubkey: PublicKey) -> Web3SignerValidatorReq
         url: web3_signer_url(),
         root_certificate_path: None,
         request_timeout_ms: None,
+        client_identity_path: None,
+        client_identity_password: None,
     }
 }
 

diff --git a/validator_client/src/initialized_validators.rs b/validator_client/src/initialized_validators.rs
@@ -260,10 +260,8 @@ impl InitializedValidator {
                 };
 
                 let builder = if let Some(path) = client_identity_path {
-                    let identity = load_pkcs12_identity(
-                        path,
-                        &client_identity_password.unwrap_or(String::new()),
-                    )?;
+                    let identity =
+                        load_pkcs12_identity(path, &client_identity_password.unwrap_or_default())?;
                     builder.identity(identity)
                 } else {
                     builder