Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ask for notification permission #3655

Conversation

elemanhillary-zz
Copy link

@elemanhillary-zz elemanhillary-zz commented Oct 9, 2019

First time contributor checklist:

Contributor checklist:

Description

This pull requests ask macOS for notification permission somehow to get macOS prompt user if he wants to allow notifications even if signal messenger has notifications disabled in preferences.

This solves #3653

- prompt user notifications permission
@elemanhillary-zz elemanhillary-zz changed the title Feature: ask for notification permission: Feature: ask for notification permission Oct 9, 2019
@scottnonnenberg-signal
Copy link
Contributor

My testing indicates that the value for Notification.permission doesn't reflect the macOS-level notification permission for Signal. Nor does asking for permissions display any kind of UI. How did you test this?

@elemanhillary-zz
Copy link
Author

My testing indicates that the value for Notification.permission doesn't reflect the macOS-level notification permission for Signal. Nor does asking for permissions display any kind of UI. How did you test this?

My testing indicates that the value for Notification.permission doesn't reflect the macOS-level notification permission for Signal. Nor does asking for permissions display any kind of UI. How did you test this?

I made sure that I don't have Signal App in the notification centre so that on starting the application it should ask for notifications permission

@scottnonnenberg-signal
Copy link
Contributor

How did you ensure that Signal was not in the notification center?

@elemanhillary-zz
Copy link
Author

elemanhillary-zz commented Oct 14, 2019

How did you ensure that Signal was not in the notification center?

Went into system preferences(MacOs catalina) and went to Notification center

@scottnonnenberg-signal
Copy link
Contributor

Again, my testing indicates that this doesn't work. Notification.permission was set to 'granted' even with macOS settings had turned off notifications. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants