Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamps sometimes fail to update #857

Closed
1 task done
tge-linee opened this issue Jul 23, 2016 · 0 comments
Closed
1 task done

Timestamps sometimes fail to update #857

tge-linee opened this issue Jul 23, 2016 · 0 comments

Comments

@tge-linee
Copy link

  • I have searched open and closed issues for duplicates

Bug description

Some of the timestamps in the message bubbles stop to get updated after a while. Same goes for the timestamps in the conversations list, altough they don't fail necessarily the same way. (e.g. the conversations list could show "53 min" and the bubble "2 hours ago" for the same message)

After I restart the app all timestamps are fixed.

This issue has been reported before (#460) but has been closed since, so I figured it would be helpful to report it again.
Possibly related: #812

Steps to reproduce

  • have a conversation

Actual result: Some timestamps fail to update.
Expected result: The timestamps should stay updated.

Screenshots

unbenannt
unbenannt

Platform info

Operating System: Windows 10
Browser: Chrome 51
Signal version: 0.17.1
@tge-linee tge-linee mentioned this issue Jul 28, 2016
Closed
2 tasks
Trolldemorted added a commit to Trolldemorted/Signal-Desktop that referenced this issue Oct 20, 2016
@Trolldemorted
Fixed bubble timestamp update timer breakdown
a673db2 
TimestampView's getRelativeTimeSpanString called moment() twice while calculating the timeout. If there was a minute/hour/day wrap between these 2 calls, the calculated delay was 0 and thus no timer was scheduled, since if (this.delay) evaluated to false.

Fixes: signalapp#857, signalapp#460

// FREEBIE
@Trolldemorted Trolldemorted mentioned this issue Oct 20, 2016
Closed
9 tasks
@liliakai liliakai mentioned this issue Oct 31, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tge-linee