Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation list not in perfect order #812

Closed
1 task done
tge-linee opened this issue Jun 3, 2016 · 8 comments
Closed
1 task done

Conversation list not in perfect order #812

tge-linee opened this issue Jun 3, 2016 · 8 comments

Comments

@tge-linee
Copy link

tge-linee commented Jun 3, 2016 •
edited
Loading

  • I have searched open and closed issues for duplicates

Bug description

The conversation list is not in perfect order. The third conversation in the list is actually the second youngest conversation.

Steps to reproduce

  • send a message in one conversation
  • send a message in another conversation

Actual result: The conversation that was active more recently is shown below the older one.
Expected result: The list should be in the right order.

Screenshots

Screenshot

Platform info

Operating System: Windows 10
Browser: Chrome

Signal version: 0.13.0

Link to debug log

https://gist.github.com/anonymous/f5a4f4ad62018f3dc3262a047da9cc9c

Edit: I send the messages
@tge-linee
Copy link
Author

Update: The timestamp of the "older" conversation in the conversation list doesn't show the right time anymore.

Screenshot2

https://gist.github.com/813e64618eeb90734d22fb7aa3bd06ab

@tge-linee
Copy link
Author

Another Update: After restarting Signal the conversation list now is in the right order and shows the right timestamps.

Screenshot3

https://gist.github.com/anonymous/e5ff507948b8f9193f9d1c9a3a65004f

@tge-linee tge-linee mentioned this issue Jul 23, 2016
Closed
1 task
@Trolldemorted
Copy link
Contributor

was the convo list out of order, or were the timestamps in the convo list incorrect?

In the latter case, this should be fixed by #948.

@tge-linee
Copy link
Author

The conversations list was out of order, as it showed it the (older) red conversation above the green. After I restarted Signal the red conversation moved down.

But: This didn't happen to me again since, so maybe it was just some weird glitch and I can close this issue?

Trolldemorted added a commit to Trolldemorted/Signal-Desktop that referenced this issue Mar 17, 2017
@Trolldemorted
fix wobbly order of conversations
fa84c89 
The 'x timeunits' string in the conversation list corresponded to the received timestamp, while the actual order of the list corresponded to the sent timestamp. This leads to inconsistent behaviour if the sent and received stamps differ.

Fixes signalapp#812
@Trolldemorted Trolldemorted mentioned this issue Mar 17, 2017
Closed
8 tasks
@Trolldemorted
Copy link
Contributor

bad news: it was not just some weird glitch, and it is still occuring with the current master
good news: i found the culprit! #1095

@tge-linee
Copy link
Author

But does that explain why the order of the list was right after a restart?

@tge-linee tge-linee reopened this Mar 17, 2017
@Trolldemorted
Copy link
Contributor

Good that you mention it, i forgot that the order was correct after restarting...

Do you understand the db query here? Which column is used to order the results? Is it always the received timestamp?

@deutrino deutrino mentioned this issue Oct 29, 2017
Open
@5a54a 5a54a mentioned this issue Jan 11, 2018
Closed
1 task
@scottnonnenberg
Copy link
Contributor

I'm gonna dupe this to the more recent bug tracking this. #1393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scottnonnenberg @Trolldemorted @tge-linee