Skip to content

feat: Adding documentation about the customizations done in the repo by Shorebird #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ open source.
* [Flutter documentation](https://docs.flutter.dev/)
* [Development wiki](https://github.com/flutter/flutter/wiki)
* [Contributing to Flutter](https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md)
* [Shorebird's customizations](./shorebird.md)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our other repos we have a shorebird/ dir and then docs/ inside that. Or just README.md inside that. This is also find though. 🤷


For announcements about new releases, follow the
[flutter-announce@googlegroups.com](https://groups.google.com/forum/#!forum/flutter-announce)
Expand Down
48 changes: 48 additions & 0 deletions shorebird.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Shorebird's change in the Flutter Repo 🐦

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to move this to either our docs site or _shorebird in the docs directory in order to keep our docs co-located. I worry that we'll lose track of all the places where we have docs otherwise 🤷

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! I added a PR there and will close this one.


This repository is the fork of the [Flutter](https://github.com/flutter/flutter) repository
with the changes necessary to support [Shorebird](https://shorebird.dev).

This document lists and explains these changes.

## Flutter Tools

The [Flutter Tools](./packages/flutter_tools) contains code that might alter the `shorebird.yaml`
file originally created by the user.

Changes on the file are done only on bundled files, and the user's file is not altered.

The changes are:

> `app_id` when using Flavors

When using Flavors, a `shorebird.yaml` might look like this:

```yaml
app_id: 1
flavors:
global: 2
internal: 3
```

When the user executes a shorebird release/patch command, using a flavor, the file will be updated
to set the app id to the flavor's app id, so if using the `internal` flavor, the file will look like this:

```yaml
app_id: 3
```

You can find these customizations in the following source files:
- [Android](https://github.com/shorebirdtech/flutter/blob/shorebird/dev/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy#L1337)
- [iOS](https://github.com/shorebirdtech/flutter/blob/shorebird/dev/packages/flutter_tools/lib/src/ios/mac.dart#L563)

> Adds `patch_public_key` when a key encoded key is provied

When an encoded public key is provided via the `SHOREBIRD_PUBLIC_KEY` environment variable. The
`shorebird.yaml` file will be updated to include the `patch_public_key` attribute containing the
value received.

This is done just on Android at this moment.

You can find these customizations in the following source files:
- [Android](https://github.com/shorebirdtech/flutter/blob/shorebird/dev/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy#L1339)
Loading