feat: Adding documentation about the customizations done in the repo by Shorebird #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itory by Shorebird
eseidel
reviewed
May 21, 2024
| @@ -26,6 +26,7 @@ open source. | |||
| * [Flutter documentation](https://docs.flutter.dev/) | |||
| * [Development wiki](https://github.com/flutter/flutter/wiki) | |||
| * [Contributing to Flutter](https://github.com/flutter/flutter/blob/master/CONTRIBUTING.md) | |||
| * [Shorebird's customizations](./shorebird.md) | |||
There was a problem hiding this comment.
In our other repos we have a shorebird/ dir and then docs/ inside that. Or just README.md inside that. This is also find though. 🤷
eseidel
approved these changes
May 21, 2024
felangel
reviewed
May 21, 2024
| @@ -0,0 +1,48 @@ | |||
| # Shorebird's change in the Flutter Repo 🐦 | |||
There was a problem hiding this comment.
Would be nice to move this to either our docs site or _shorebird in the docs directory in order to keep our docs co-located. I worry that we'll lose track of all the places where we have docs otherwise 🤷
There was a problem hiding this comment.
Agreed! I added a PR there and will close this one.
|
Closing this in favor of Felix's comment: #50 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this internal note which were helping me navigate through the changes that we made in flutter tools, thought it could be interesting to put a PR with it so more people could benefit from them.