This repository was archived by the owner on Feb 14, 2025. It is now read-only.
forked from flutter/engine
-
Notifications
You must be signed in to change notification settings - Fork 12
Move configure shorebird call to platform embedder #95
Draft
bryanoltman
wants to merge
18
commits into
shorebird/dev
Choose a base branch
from
bo/configure-shorebird-refactor
base: shorebird/dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See shorebird/dev-3.24.5 for prior commit history.
* fix: update how we generate analyze_snapshot * formatting
…-export shorebird_check_for_update)
* chore: squash all our changes to a single commit See shorebird/dev-3.24.5 for prior commit history. * fix: remove flutter/fml/size include * fix: use shorebird buildroot * fix: generate analyze snapshot for arm builds * formatting * fix: update how we generate analyze_snapshot (#92) * fix: update how we generate analyze_snapshot * formatting * build windows * Windows Support * Format * Make patching work * Formatting * Formatting * Formatting * Improve windows * Formatting * Formatting * Formatting * Revert unneeded changes * Revert changes * Bump updater rev * Remove prints * Cleanup * fix deps * Use correct local appdata path * Formatting * consolidate fetching build number and release version * format * remove unnecessary pointer * Introduce ReleaseVersion struct * formatting * Formatting * More formatting * Comments * Formatting * More comments * Formatting * Remove print statements * Remove comments * Use in-out param for ConfigureShorebird * formatting * fix deps * Remove extra include of updater.lib * Cleanup * cleanup * Formatting * Use ERROR_SUCCESS * Do not use Error Success * Add comment * GetLocalAppDataPath feedback * Refactor --------- Co-authored-by: Felix Angelov <felix@shorebird.dev>
682c87b to
d49c3f3
Compare
899fa53 to
72a6ccc
Compare
897caef to
e4575c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This crashes on launch, trying to figure out why