Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEXT-37315 - trigger indexing by default #9

Merged
merged 1 commit into from
Jul 29, 2024
Merged

NEXT-37315 - trigger indexing by default #9

merged 1 commit into from
Jul 29, 2024

Conversation

LarsKemper
Copy link
Member

@LarsKemper LarsKemper commented Jul 25, 2024 •
edited
Loading

blocked by: #8

@LarsKemper LarsKemper self-assigned this Jul 25, 2024
MalteJanz
MalteJanz previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@MalteJanz MalteJanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LarsKemper LarsKemper force-pushed the next-37316/add-trigger-indexing-command branch 2 times, most recently from 75e0eea to b57c094 Compare July 26, 2024 08:40
Base automatically changed from next-37316/add-trigger-indexing-command to main July 29, 2024 11:31
@LarsKemper LarsKemper dismissed MalteJanz’s stale review July 29, 2024 11:31

The base branch was changed.

MalteJanz
MalteJanz reviewed Jul 29, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@LarsKemper LarsKemper force-pushed the next-37315/trigger-indexing-by-default branch from 20fb965 to b012ab2 Compare July 29, 2024 11:45
@LarsKemper LarsKemper requested a review from MalteJanz July 29, 2024 11:46
@LarsKemper LarsKemper removed the wip label Jul 29, 2024
@LarsKemper LarsKemper merged commit 6a69ee3 into main Jul 29, 2024
3 checks passed
@LarsKemper LarsKemper deleted the next-37315/trigger-indexing-by-default branch July 29, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalteJanz MalteJanz MalteJanz approved these changes

@jozsefdamokos jozsefdamokos Awaiting requested review from jozsefdamokos

@DennisGarding DennisGarding Awaiting requested review from DennisGarding

@ennasus4sun ennasus4sun Awaiting requested review from ennasus4sun

Assignees

@LarsKemper LarsKemper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarsKemper @MalteJanz