Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEXT-37316 - add trigger indexing command #8

Merged
merged 2 commits into from
Jul 29, 2024
Merged

NEXT-37316 - add trigger indexing command #8

merged 2 commits into from
Jul 29, 2024

Conversation

LarsKemper
Copy link
Member

No description provided.

@LarsKemper LarsKemper added the enhancement New feature or request label Jul 25, 2024
@LarsKemper LarsKemper self-assigned this Jul 25, 2024
@LarsKemper LarsKemper force-pushed the next-37316/add-trigger-indexing-command branch 3 times, most recently from ae8d8ea to 19c8408 Compare July 25, 2024 13:24
@LarsKemper LarsKemper mentioned this pull request Jul 25, 2024
Merged
MalteJanz
MalteJanz requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@MalteJanz MalteJanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work 🎉 👍 , only found some minor things 🙂

src/api/mod.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/api/mod.rs Outdated Show resolved Hide resolved
@LarsKemper LarsKemper force-pushed the next-37316/add-trigger-indexing-command branch from 19c8408 to 75e0eea Compare July 26, 2024 08:39
@LarsKemper LarsKemper force-pushed the next-37316/add-trigger-indexing-command branch from 75e0eea to b57c094 Compare July 26, 2024 08:40
@LarsKemper LarsKemper requested a review from MalteJanz July 29, 2024 06:03
MalteJanz
MalteJanz previously approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@MalteJanz MalteJanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise it LGTM 👍

src/main.rs Outdated Show resolved Hide resolved
@LarsKemper LarsKemper requested a review from MalteJanz July 29, 2024 07:34
@LarsKemper LarsKemper merged commit 25efd7d into main Jul 29, 2024
3 checks passed
@LarsKemper LarsKemper deleted the next-37316/add-trigger-indexing-command branch July 29, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalteJanz MalteJanz MalteJanz approved these changes

@jozsefdamokos jozsefdamokos Awaiting requested review from jozsefdamokos

@DennisGarding DennisGarding Awaiting requested review from DennisGarding

@ennasus4sun ennasus4sun Awaiting requested review from ennasus4sun

Assignees

@LarsKemper LarsKemper

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarsKemper @MalteJanz