Skip to content

Conversation

@cyl3x
Copy link
Contributor

@cyl3x cyl3x commented Oct 10, 2025

orderVariantsByPricePerMonth and orderVariantsByRentDuration are used in computed values. Array.sort will sort the array in place, mutating the value used in computed values, resulting in infinite recursion.

fixes shopware/shopware#12955

@cyl3x cyl3x requested review from a team and kaigossel October 10, 2025 08:11
@cyl3x cyl3x self-assigned this Oct 10, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.00%. Comparing base (f5dc076) to head (ff3bd05).

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #121      +/-   ##
============================================
- Coverage     70.57%   68.00%   -2.58%     
============================================
  Files            37       29       -8     
  Lines          1186      825     -361     
  Branches        153      153              
============================================
- Hits            837      561     -276     
+ Misses          324      239      -85     
  Partials         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyl3x cyl3x merged commit b467d44 into trunk Oct 10, 2025
3 checks passed
@cyl3x cyl3x deleted the fix/open-extension-buy-modal branch October 10, 2025 08:16
kaigossel pushed a commit that referenced this pull request Oct 13, 2025
kaigossel pushed a commit that referenced this pull request Oct 13, 2025
kaigossel added a commit that referenced this pull request Oct 14, 2025
* ECTO-2133 - Implement yearly rent variant (#116)

* ECTO-2150 - Add yearly variant to listing
* ECTO-2151 - Add yearly variant to detail page
* ECTO-2136 - Add yearly variant to checkout modal

* fix: open extension buy modal (#121)

---------

Co-authored-by: Michel <m.bade@shopware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SwagExtensionStore: purchasing extensions through administration freezes the administration

6 participants