Skip to content

ECTO-2133 - Implement yearly rent variant #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaigossel merged 6 commits into from
Oct 7, 2025
Merged

ECTO-2133 - Implement yearly rent variant #116

kaigossel merged 6 commits into from
Oct 7, 2025

Conversation

@kaigossel
Copy link
Collaborator

@kaigossel kaigossel commented Sep 29, 2025

No description provided.

@kaigossel kaigossel self-assigned this Sep 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 98.37398% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.38%. Comparing base (b38765a) to head (a4607ae).

Files with missing lines Patch % Lines
...inistration/src/module/sw-extension-store/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              trunk     #116      +/-   ##
============================================
+ Coverage     68.89%   69.38%   +0.49%     
============================================
  Files            35       28       -7     
  Lines          1064      797     -267     
  Branches        126      146      +20     
============================================
- Hits            733      553     -180     
+ Misses          302      219      -83     
+ Partials         29       25       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaigossel kaigossel requested review from FloBWer, cyl3x and qysp October 1, 2025 13:20
@kaigossel kaigossel merged commit 0850d5e into trunk Oct 7, 2025
3 checks passed
@kaigossel kaigossel deleted the epic/ECTO-2133 branch October 7, 2025 06:17
kaigossel added a commit that referenced this pull request Oct 7, 2025
@kaigossel
ECTO-2133 - Implement yearly rent variant (#116)
0dce994 
* ECTO-2150 - Add yearly variant to listing
* ECTO-2151 - Add yearly variant to detail page
* ECTO-2136 - Add yearly variant to checkout modal
kaigossel added a commit that referenced this pull request Oct 13, 2025
@kaigossel
ECTO-2133 - Implement yearly rent variant (#116)
3fd36ae 
* ECTO-2150 - Add yearly variant to listing
* ECTO-2151 - Add yearly variant to detail page
* ECTO-2136 - Add yearly variant to checkout modal
kaigossel added a commit that referenced this pull request Oct 13, 2025
@kaigossel
ECTO-2133 - Implement yearly rent variant (#116)
89e6173 
* ECTO-2150 - Add yearly variant to listing
* ECTO-2151 - Add yearly variant to detail page
* ECTO-2136 - Add yearly variant to checkout modal
kaigossel added a commit that referenced this pull request Oct 14, 2025
@kaigossel @cyl3x
ECTO-2133 - Implement yearly rent variant (#116) (#118)
684b2af 
* ECTO-2133 - Implement yearly rent variant (#116)

* ECTO-2150 - Add yearly variant to listing
* ECTO-2151 - Add yearly variant to detail page
* ECTO-2136 - Add yearly variant to checkout modal

* fix: open extension buy modal (#121)

---------

Co-authored-by: Michel <m.bade@shopware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloBWer FloBWer FloBWer approved these changes

@qysp qysp qysp approved these changes

@cyl3x cyl3x cyl3x approved these changes

Assignees

@kaigossel kaigossel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kaigossel @codecov-commenter @FloBWer @qysp @cyl3x