Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember 5 typescript fix #1736

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Ember 5 typescript fix #1736

merged 1 commit into from
Aug 9, 2023

Conversation

BobrImperator
Copy link
Contributor

@BobrImperator BobrImperator commented Jul 30, 2023 •
edited
Loading

It seems like it's not possible to extend a service while using typescript.
This was a hunch of mine related to some typescript race conditions during ember builds from a while back.
It seems like the project also already does this for the cognito service.

@BobrImperator BobrImperator changed the base branch from main to ember-5 July 30, 2023 00:43
@BobrImperator
Copy link
Contributor Author

BobrImperator commented Jul 30, 2023 •
edited
Loading

@RobbieTheWagner

image

@BobrImperator BobrImperator mentioned this pull request Jul 30, 2023
Merged
@RobbieTheWagner
Copy link
Member

Ahhhh thanks @BobrImperator and sorry for the noise 😅

@RobbieTheWagner RobbieTheWagner merged commit 3596541 into shipshapecode:ember-5 Aug 9, 2023
@BobrImperator BobrImperator deleted the ember-5-typescript-fix branch August 10, 2023 15:31
RobbieTheWagner added a commit that referenced this pull request Aug 10, 2023
@RobbieTheWagner @BobrImperator
Ember 5 (#1732)
81548b5 
* Ember 5

* Get running on Ember 5

* Lint fix

* feat: conver session to javascript, unable to extend service with typescript (#1736)

---------

Co-authored-by: Bartlomiej Dudzik <bartholomew.dudzik@gmail.com>
@BobrImperator BobrImperator mentioned this pull request Dec 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobrImperator @RobbieTheWagner