feat(ember-simple-auth): remove app re-exports #2895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
services/session
andsession-stores/application
files.They must be imported by users themselves.
This change is made due to processing problems found here #2888 and shipshapecode/swach#1736.
It's been a problem for a long time and with Ember-Data and Ember itself being more explicit around dependencies, we should make the switch too.
The only thing that ESA will continue to export is the initializer, they aren't usually imported and extended by users so they shouldn't cause problems as long as Ember still supports it.
Migration guide:
Add
app/services/session.js
orapp/services/session.ts
Add
app/session-stores/application.js
orapp/session-stores/application.ts