Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ember-simple-auth): remove app re-exports #2895

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Dec 29, 2024

  • Removes app re-exports , meaning that Ember-Simple-Auth will no longer automatically add services/session and session-stores/application files.
    They must be imported by users themselves.

This change is made due to processing problems found here #2888 and shipshapecode/swach#1736.
It's been a problem for a long time and with Ember-Data and Ember itself being more explicit around dependencies, we should make the switch too.

The only thing that ESA will continue to export is the initializer, they aren't usually imported and extended by users so they shouldn't cause problems as long as Ember still supports it.

Migration guide:

Add app/services/session.js or app/services/session.ts

import Service from 'ember-simple-auth/services/session';

export default class SessionService extends Service {}

Add app/session-stores/application.js or app/session-stores/application.ts

import AdaptiveStore from 'ember-simple-auth/session-stores/adaptive';

export default class SessionStore extends AdaptiveStore {}

@BobrImperator BobrImperator force-pushed the remove-app-reexports branch 2 times, most recently from ea029a9 to f47274c Compare December 29, 2024 18:47
Copy link

Some tests with 'continue-on-error: true' have failed:

  • classic-test-app test:one ember-canary

Created by continue-on-error-comment

Copy link

github-actions bot commented Dec 29, 2024

Some tests with 'continue-on-error: true' have failed:

  • classic-test-app test:one ember-canary

  • test-app test:one ember-beta

  • test-app test:one ember-canary

  • classic-test-app test:one ember-beta

    Created by continue-on-error-comment

@BobrImperator BobrImperator merged commit 4d925a9 into master Dec 29, 2024
40 of 42 checks passed
@BobrImperator BobrImperator deleted the remove-app-reexports branch December 29, 2024 18:50
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant